Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Issue 1410223006: Zero-initialize persistent heap vector inline backing buffers. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Zero-initialize persistent heap vector inline backing buffers. A persistent heap collection object is allocated off-heap, along with its inlined buffer (if any.) For heap-allocated backing buffers (inlined in a heap vector or separate), the Oilpan allocator will provide a zero-initialized chunk of memory to use. Consequently the invariant initially holds that unused slots of the backing buffer are all zero initialized -- something needed for precise tracing during GC marking To have that invariant hold for the persistent heap vectors also, we have to explicitly clear out the inline backing buffers on (off-heap) allocation. R=haraken BUG=420515 Committed: https://crrev.com/641847a603e69022bb65d5a466c0836269c63e9b Cr-Commit-Position: refs/heads/master@{#356014}

Patch Set 1 #

Patch Set 2 : for unit test, handle ANNOTATE_CONTIGUOUS_CONTAINER's non-support of inline buffers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -5 lines) Patch
M third_party/WebKit/Source/platform/heap/Handle.h View 1 chunk +23 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/Vector.h View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sof
please take a look. Takes care of the cause of this crasher, https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oilpan__dbg_/5090/layout-test-results/results.html i.e., (off)heap ...
5 years, 1 month ago (2015-10-25 15:12:01 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410223006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410223006/20001
5 years, 1 month ago (2015-10-25 18:18:27 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-25 19:13:31 UTC) #5
haraken
LGTM
5 years, 1 month ago (2015-10-26 06:47:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410223006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410223006/20001
5 years, 1 month ago (2015-10-26 07:03:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-26 07:08:32 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 07:09:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/641847a603e69022bb65d5a466c0836269c63e9b
Cr-Commit-Position: refs/heads/master@{#356014}

Powered by Google App Engine
This is Rietveld 408576698