Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: test/lib/TestGyp.py

Issue 1410213005: win: Fix missing loadable_module dependency in ULDI mode (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: all-generators Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/lib/TestCommon.py ('k') | test/win/gyptest-link-uldi-depending-on-module.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/lib/TestGyp.py
diff --git a/test/lib/TestGyp.py b/test/lib/TestGyp.py
index bf7afe1bbf7b9fc84ca16c9dcd66d504c578ada9..c59b811a8d9f295927a68f4f3795e8b99f9e31df 100644
--- a/test/lib/TestGyp.py
+++ b/test/lib/TestGyp.py
@@ -89,6 +89,8 @@ class TestGypBase(TestCommon.TestCommon):
_lib = TestCommon.lib_suffix
dll_ = TestCommon.dll_prefix
_dll = TestCommon.dll_suffix
+ module_ = TestCommon.module_prefix
+ _module = TestCommon.module_suffix
# Constants to represent different targets.
ALL = '__all__'
@@ -98,6 +100,7 @@ class TestGypBase(TestCommon.TestCommon):
EXECUTABLE = '__executable__'
STATIC_LIB = '__static_lib__'
SHARED_LIB = '__shared_lib__'
+ LOADABLE_MODULE = '__loadable_module__'
def __init__(self, gyp=None, *args, **kw):
self.origin_cwd = os.path.abspath(os.path.dirname(sys.argv[0]))
@@ -361,6 +364,8 @@ class TestGypBase(TestCommon.TestCommon):
name = self.lib_ + name + self._lib
elif type == self.SHARED_LIB:
name = self.dll_ + name + self._dll
+ elif type == self.LOADABLE_MODULE:
+ name = self.module_ + name + self._module
return name
def run_built_executable(self, name, *args, **kw):
« no previous file with comments | « test/lib/TestCommon.py ('k') | test/win/gyptest-link-uldi-depending-on-module.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698