Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: tools/telemetry/telemetry/core/chrome/desktop_browser_backend.py

Issue 14102002: Better support for chrome for cros local builds. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: nduca feedback Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/chrome/desktop_browser_backend.py
===================================================================
--- tools/telemetry/telemetry/core/chrome/desktop_browser_backend.py (revision 194244)
+++ tools/telemetry/telemetry/core/chrome/desktop_browser_backend.py (working copy)
@@ -16,7 +16,7 @@
"""The backend for controlling a locally-executed browser instance, on Linux,
Mac or Windows.
"""
- def __init__(self, options, executable, is_content_shell):
+ def __init__(self, options, executable, is_content_shell, use_login):
super(DesktopBrowserBackend, self).__init__(
is_content_shell=is_content_shell,
supports_extensions=not is_content_shell, options=options)
@@ -26,6 +26,8 @@
self._tmpdir = None
self._tmp_output_file = None
+ self._use_login = use_login
+
self._executable = executable
if not self._executable:
raise Exception('Cannot create browser, no executable found!')
@@ -45,7 +47,7 @@
self._supports_net_benchmarking = False
self._LaunchBrowser(options)
- if self.options.cros_desktop:
+ if self._use_login:
cros_util.NavigateLogin(self)
def _LaunchBrowser(self, options):
@@ -83,7 +85,7 @@
shutil.rmtree(self._tmpdir)
shutil.copytree(self.options.profile_dir, self._tmpdir)
args.append('--user-data-dir=%s' % self._tmpdir)
- if self.options.cros_desktop:
+ if self._use_login:
ext_path = os.path.join(os.path.dirname(__file__), 'chromeos_login_ext')
args.extend(['--login-manager', '--login-profile=user',
'--stub-cros', '--login-screen=login',
« no previous file with comments | « tools/telemetry/telemetry/core/browser_options.py ('k') | tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698