Issue 141020: Make gtk url picker and edit keyword view modal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141020: Make gtk url picker and edit keyword view modal. (Closed)

Created:
11 years, 6 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make gtk url picker and edit keyword view modal. Don't like that GTK only does app-modal rather than window modal, but otherwise you can just close the parent window and crash when you then click okay on the dialog. BUG=11507 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18887

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	chrome/browser/gtk/edit_keyword_controller.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	chrome/browser/gtk/options/url_picker_dialog_gtk.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mattm

(EditKeywordController could be non-model when it isn't passed a delegate (ie, when you get to ...

11 years, 6 months ago (2009-06-20 02:34:17 UTC) #1

Evan Martin

11 years, 6 months ago (2009-06-20 02:38:03 UTC) #2

The app-modal thing is http://code.google.com/p/chromium/issues/detail?id=8727 ,
btw.

LGTM

Expand Messages | Collapse Messages