Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 141020: Make gtk url picker and edit keyword view modal. (Closed)

Created:
11 years, 6 months ago by mattm
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make gtk url picker and edit keyword view modal. Don't like that GTK only does app-modal rather than window modal, but otherwise you can just close the parent window and crash when you then click okay on the dialog. BUG=11507 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/gtk/edit_keyword_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/gtk/options/url_picker_dialog_gtk.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mattm
(EditKeywordController could be non-model when it isn't passed a delegate (ie, when you get to ...
11 years, 6 months ago (2009-06-20 02:34:17 UTC) #1
Evan Martin
11 years, 6 months ago (2009-06-20 02:38:03 UTC) #2
The app-modal thing is http://code.google.com/p/chromium/issues/detail?id=8727 ,
btw.

LGTM

Powered by Google App Engine
This is Rietveld 408576698