Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1410163005: [heap] Use live memory as heuristic for spawning compaction tasks (Closed)

Created:
5 years, 1 month ago by Michael Lippautz
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Use live memory as heuristic for spawning compaction tasks R=hpayer@chromium.org BUG=chromium:524425 LOG=N Committed: https://crrev.com/88b764d7f74008fe5f30d59e3881e374d538b72e Cr-Commit-Position: refs/heads/master@{#31725}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/heap/mark-compact.cc View 1 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/1410163005/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1410163005/diff/1/src/heap/mark-compact.cc#newcode3316 src/heap/mark-compact.cc:3316: const int kLiveMemoryPerCompactionTask = 2 * Page::kPageSize; We ...
5 years, 1 month ago (2015-11-02 23:44:38 UTC) #1
Michael Lippautz
https://codereview.chromium.org/1410163005/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1410163005/diff/1/src/heap/mark-compact.cc#newcode3316 src/heap/mark-compact.cc:3316: const int kLiveMemoryPerCompactionTask = 2 * Page::kPageSize; On 2015/11/02 ...
5 years, 1 month ago (2015-11-02 23:48:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410163005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410163005/20001
5 years, 1 month ago (2015-11-02 23:49:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-03 00:04:14 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 00:04:58 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88b764d7f74008fe5f30d59e3881e374d538b72e
Cr-Commit-Position: refs/heads/master@{#31725}

Powered by Google App Engine
This is Rietveld 408576698