third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-resource.html - Issue 1410153009: DevTools: Make network events continuous on Timeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-resource.html

Issue 1410153009: DevTools: Make network events continuous on Timeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments #2 Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-received-data.html ('k') | third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-resource-expected.txt » ('j') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-resource.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-resource.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-resource.html

index 8091c8ef356e3787639dd7027de4521ffaaa07c1..6b6de1c92db4ce1146f07abeab33801fe7c6aba6 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-resource.html

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-resource.html

@@ -29,11 +29,11 @@ function test()

var lastRecordStartTime;

function format(record)

{

- if (record.type() === WebInspector.TimelineModel.RecordType.ResourceSendRequest)

+ if (record.type() === WebInspector.TimelineModel.RecordType.ResourceFetcherRequestResource)

printSend(record);

- else if (record.type() === WebInspector.TimelineModel.RecordType.ResourceReceiveResponse)

+ else if (record.type() === WebInspector.TimelineModel.RecordType.ResourceDispatcherOnReceivedResponse)

printReceive(record);

- else if (record.type() === WebInspector.TimelineModel.RecordType.ResourceFinish)

+ else if (record.type() === WebInspector.TimelineModel.RecordType.ResourceDispatcherOnRequestComplete)

printFinish(record);

var presentationRecord = presentationModel.toPresentationRecord(record);