third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-received-data.html - Issue 1410153009: DevTools: Make network events continuous on Timeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-received-data.html

Issue 1410153009: DevTools: Make network events continuous on Timeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/tracing/category-filter.html ('K') | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-model-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-resource.html » ('j') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-received-data.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-received-data.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-received-data.html

index a7372e67c1d606ab01f60c6ebecb41f394292175..2a07401c62f03859450dd73b70a1bc564c435991 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-received-data.html

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network-received-data.html

@@ -37,10 +37,10 @@ function test()

function done()

{

InspectorTest.addResult("Script evaluated.");

- var record = InspectorTest.findFirstTimelineRecord("ResourceReceivedData");

+ var record = InspectorTest.findFirstTimelineRecord("ResourceDispatcher::OnReceivedData");

if (record) {

var data = record.traceEvent().args["data"];

- if (data && typeof data.encodedDataLength === "number")

+ if (data && typeof data["encodedDataLength"] === "number")

InspectorTest.addResult("Resource received data has length, test passed.");

}

InspectorTest.completeTest();