Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

Issue 1410153009: DevTools: Make network events continuous on Timeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
index 87ce97e28f759261060b1cd0992e880aedb68d6f..23b2861388c9b45f524f3d7c60de944a68ab429b 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
@@ -222,13 +222,10 @@ InspectorTest.innerPrintTimelinePresentationRecords = function(records, typeName
// Dump just the record name, indenting output on separate lines for subrecords
InspectorTest.dumpTimelineRecord = function(record, detailsCallback, level, filterTypes)
{
- if (typeof level !== "number")
- level = 0;
- var message = "";
- for (var i = 0; i < level ; ++i)
- message = "----" + message;
+ level = level || 0;
+ var message = "----".repeat(level);
if (level > 0)
- message = message + "> ";
+ message += "> ";
if (record.type() === WebInspector.TimelineModel.RecordType.TimeStamp
|| record.type() === WebInspector.TimelineModel.RecordType.ConsoleTime) {
message += WebInspector.TimelineUIUtils.eventTitle(record.traceEvent());
@@ -250,13 +247,10 @@ InspectorTest.dumpTimelineRecord = function(record, detailsCallback, level, filt
InspectorTest.dumpTimelineModelRecord = function(record, level)
{
- if (typeof level !== "number")
- level = 0;
- var prefix = "";
- for (var i = 0; i < level ; ++i)
- prefix = "----" + prefix;
+ level = level || 0;
+ var prefix = "----".repeat(level);
if (level > 0)
- prefix = prefix + "> ";
+ prefix += "> ";
InspectorTest.addResult(prefix + record.type() + ": " + (WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent(record.traceEvent(), null) || ""));
var numChildren = record.children() ? record.children().length : 0;
@@ -268,13 +262,10 @@ InspectorTest.dumpTimelineModelRecord = function(record, level)
InspectorTest.dumpPresentationRecord = function(presentationRecord, detailsCallback, level, filterTypes)
{
var record = !presentationRecord.presentationParent() ? null : presentationRecord.record();
- if (typeof level !== "number")
- level = 0;
- var message = "";
- for (var i = 0; i < level ; ++i)
- message = "----" + message;
+ level = level || 0;
+ var message = "----".repeat(level);
if (level > 0)
- message = message + "> ";
+ message += "> ";
if (!record) {
message += "Root";
} else if (presentationRecord.coalesced()) {

Powered by Google App Engine
This is Rietveld 408576698