DevTools: Make network events continuous on Timeline

content/child/resource_dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/child/resource_dispatcher.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 132 matching lines @@
     return;
 
   request_info->peer->OnUploadProgress(position, size);
 
   // Acknowledge receipt
   message_sender_->Send(new ResourceHostMsg_UploadProgress_ACK(request_id));
 }
 
 void ResourceDispatcher::OnReceivedResponse(
     int request_id, const ResourceResponseHead& response_head) {
-  TRACE_EVENT0("loader", "ResourceDispatcher::OnReceivedResponse");
+  TRACE_EVENT0("loader,devtools.timeline",
+               "ResourceDispatcher::OnReceivedResponse");

[caseq, 2015/11/06 19:37:47]

If we start exposing this in devtools trace, can we name this in a more stable
manner, i.e. independent on class/name method.

[alph, 2015/11/06 21:04:51]

We can't change this name as it seems to be used elsewhere. And I don't think
it's feasible to introduce another event just for DevTools purposes.

   PendingRequestInfo* request_info = GetPendingRequestInfo(request_id);
   if (!request_info)
     return;
   request_info->response_start = ConsumeIOTimestamp();
 
   if (delegate_) {
     RequestPeer* new_peer =
         delegate_->OnReceivedResponse(
             request_info->peer, response_head.mime_type, request_info->url);
     if (new_peer)
@@ skipping 55 matching lines @@
   // TODO(erikchen): Temporary debugging. http://crbug.com/527588.
   CHECK_GE(shm_size, 0);
   CHECK_LE(shm_size, 512 * 1024);
   request_info->buffer_size = shm_size;
 }
 
 void ResourceDispatcher::OnReceivedData(int request_id,
                                         int data_offset,
                                         int data_length,
                                         int encoded_data_length) {
-  TRACE_EVENT0("loader", "ResourceDispatcher::OnReceivedData");
+  TRACE_EVENT0("loader,devtools.timeline",
+               "ResourceDispatcher::OnReceivedData");
   DCHECK_GT(data_length, 0);
   PendingRequestInfo* request_info = GetPendingRequestInfo(request_id);
   bool send_ack = true;
   if (request_info && data_length > 0) {
     // TODO(erikchen): Temporary debugging. http://crbug.com/550938.
     CHECK(request_info->has_processed_buffer);
     CHECK(!request_info->has_destroyed_buffer);
     CHECK(request_info->buffer.get());
 
     CHECK(base::SharedMemory::IsHandleValid(request_info->buffer->handle()));
@@ skipping 100 matching lines @@
     int request_id,
     PendingRequestInfo& request_info) {
   IPC::Message* msg = request_info.pending_redirect_message.release();
   if (msg)
     message_sender_->Send(msg);
 }
 
 void ResourceDispatcher::OnRequestComplete(
     int request_id,
     const ResourceMsg_RequestCompleteData& request_complete_data) {
-  TRACE_EVENT0("loader", "ResourceDispatcher::OnRequestComplete");
+  TRACE_EVENT0("loader,devtools.timeline",
+               "ResourceDispatcher::OnRequestComplete");
 
   PendingRequestInfo* request_info = GetPendingRequestInfo(request_id);
   if (!request_info)
     return;
   request_info->completion_time = ConsumeIOTimestamp();
   request_info->buffer.reset();
   request_info->has_destroyed_buffer = true;
   if (request_info->received_data_factory)
     request_info->received_data_factory->Stop();
   request_info->received_data_factory = nullptr;
@@ skipping 472 matching lines @@
     *frame_origin = extra_data->frame_origin();
   return request.Pass();
 }
 
 void ResourceDispatcher::SetResourceSchedulingFilter(
     scoped_refptr<ResourceSchedulingFilter> resource_scheduling_filter) {
   resource_scheduling_filter_ = resource_scheduling_filter;
 }
 
 }  // namespace content