Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1410153007: Revert of win: Update to Win 10 SDK (Closed)

Created:
5 years, 1 month ago by caseq
Modified:
5 years, 1 month ago
Reviewers:
brucedawson, sky, scottmg
CC:
chromium-reviews, tfarina, Nico, Jim Stichnoth, Petr Hosek, Karl, Junichi Uekawa, Sam Clegg, cdotstout, Roland McGrath
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of win: Update to Win 10 SDK (patchset #8 id:140001 of https://codereview.chromium.org/1378153003/ ) Reason for revert: This is a suspect in breaking Win bots (e.g. here http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/93039) Original issue's description: > win: Update to Win 10 SDK > > Tested on clean Win7 VM against both VS2013 and clang=1 at 247874-1. > > R=brucedawson@chromium.org > BUG=491424 > > Committed: https://crrev.com/3f6f89251dc210b24a36398237d374a87d4a3b33 > Cr-Commit-Position: refs/heads/master@{#352667} > > Committed: https://crrev.com/1feffb4b7b1c2bfaf112a8993ae7ab0c16a52da9 > Cr-Commit-Position: refs/heads/master@{#356373} TBR=brucedawson@chromium.org,sky@chromium.org,scottmg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=491424 Committed: https://crrev.com/e4a933bfce1dce211b29c392a681513a9d69a85c Cr-Commit-Position: refs/heads/master@{#356484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -22 lines) Patch
M build/common.gypi View 5 chunks +12 lines, -12 lines 0 comments Download
M build/config/win/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M build/vs_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_win.cc View 2 chunks +23 lines, -2 lines 0 comments Download
M third_party/usrsctp/usrsctp.gyp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
caseq
Created Revert of win: Update to Win 10 SDK
5 years, 1 month ago (2015-10-28 01:49:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410153007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410153007/1
5 years, 1 month ago (2015-10-28 01:50:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 01:52:34 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e4a933bfce1dce211b29c392a681513a9d69a85c Cr-Commit-Position: refs/heads/master@{#356484}
5 years, 1 month ago (2015-10-28 01:54:07 UTC) #4
scottmg
On 2015/10/28 01:54:07, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 1 month ago (2015-10-28 16:53:58 UTC) #5
scottmg
5 years ago (2015-12-04 18:40:19 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1502563003/ by scottmg@chromium.org.

The reason for reverting is: Relanding, we think all bots are updated now..

Powered by Google App Engine
This is Rietveld 408576698