components/copresence/proto/enums.proto - Issue 1410153003: Browser frame for Aura Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/copresence/proto/enums.proto

Issue 1410153003: Browser frame for Aura Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed unrelated changes + formatting. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 syntax = "proto2";	1 syntax = "proto2";

2 package copresence;	2 package copresence;

3 option optimize_for = LITE_RUNTIME;	3 option optimize_for = LITE_RUNTIME;

4 enum IdentityType {	4 enum IdentityType {

5 IDENTITY_TYPE_UNKNOWN = 0;	5 IDENTITY_TYPE_UNKNOWN = 0;

6 GAIA_USER = 1;	6 GAIA_USER = 1;

7 CHROMECAST = 2;	7 CHROMECAST = 2;

8 ANDROID = 3;	8 ANDROIDOS = 3;
	no sievers 2015/10/28 20:04:51 why this change? why this change? Hadi 2015/10/29 15:27:02 When we compile for android, g++ gets the flag "-D Show quoted text On 2015/10/28 20:04:51, sievers wrote: > why this change? When we compile for android, g++ gets the flag "-DANDROID", and then pre-processor removes every ANDROID in the code and we get some compile errors. This change was to avoid this situation. bshe 2015/10/30 16:29:10 It would be nice to land this change separately in Show quoted text On 2015/10/29 15:27:02, Hadi wrote: > On 2015/10/28 20:04:51, sievers wrote: > > why this change? > > When we compile for android, g++ gets the flag "-DANDROID", and then > pre-processor removes every ANDROID in the code and we get some compile errors. > This change was to avoid this situation. It would be nice to land this change separately in a different CL. It doesnt seem to directly relate to other changes in this CL. Hadi 2015/11/02 14:47:40 Moved this to 1415533018. Show quoted text On 2015/10/30 16:29:10, bshe wrote: > On 2015/10/29 15:27:02, Hadi wrote: > > On 2015/10/28 20:04:51, sievers wrote: > > > why this change? > > > > When we compile for android, g++ gets the flag "-DANDROID", and then > > pre-processor removes every ANDROID in the code and we get some compile > errors. > > This change was to avoid this situation. > > It would be nice to land this change separately in a different CL. It doesnt > seem to directly relate to other > changes in this CL. Moved this to 1415533018.
9 CHROME = 4;	9 CHROME = 4;

10 UNREGISTERED = 5;	10 UNREGISTERED = 5;

11 }	11 }

12 enum PushService {	12 enum PushService {

13 PUSH_SERVICE_UNKNOWN = 0;	13 PUSH_SERVICE_UNKNOWN = 0;

14 GCM = 1;	14 GCM = 1;

15 APNS = 2;	15 APNS = 2;

16 PUSH_SERVICE_NONE = 3;	16 PUSH_SERVICE_NONE = 3;

17 }	17 }

18 enum ErrorType {	18 enum ErrorType {

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
82 enum AudioConfiguration {	82 enum AudioConfiguration {

83 AUDIO_CONFIGURATION_UNKNOWN = 0;	83 AUDIO_CONFIGURATION_UNKNOWN = 0;

84 AUDIO_CONFIGURATION_AUDIBLE = 1;	84 AUDIO_CONFIGURATION_AUDIBLE = 1;

85 }	85 }

86 enum BroadcastScanConfiguration {	86 enum BroadcastScanConfiguration {

87 BROADCAST_SCAN_CONFIGURATION_UNKNOWN = 0;	87 BROADCAST_SCAN_CONFIGURATION_UNKNOWN = 0;

88 BROADCAST_AND_SCAN = 1;	88 BROADCAST_AND_SCAN = 1;

89 BROADCAST_ONLY = 2;	89 BROADCAST_ONLY = 2;

90 SCAN_ONLY = 3;	90 SCAN_ONLY = 3;

91 }	91 }

OLD	NEW

« chrome/chrome_browser_ui.gypi ('K') | « chrome/chrome_browser_ui.gypi ('k') | ui/aura/window_tree_host_platform.h » ('j') | ui/aura/window_tree_host_platform.h » ('J')