Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #include "chrome/browser/ui/views/frame/browser_frame_android.h" | |
| 6 | |
| 7 #include "chrome/browser/ui/views/frame/browser_shutdown.h" | |
| 8 #include "chrome/browser/ui/views/frame/browser_view.h" | |
| 9 #include "ui/aura/window.h" | |
| 10 #include "ui/aura/window_tree_host_platform.h" | |
| 11 | |
| 12 // A stripped version of BrowserFrameAsh. May need to add things back later. | |
|
msw
2015/11/02 21:40:01
nit: move comment to header?
mfomitchev
2015/11/02 23:00:17
We should probably get rid of this comment altoget
Hadi
2015/11/03 18:48:47
Done.
| |
| 13 | |
| 14 /////////////////////////////////////////////////////////////////////////////// | |
| 15 // BrowserFrameAndroid, public: | |
| 16 | |
| 17 // static | |
| 18 const char BrowserFrameAndroid::kWindowName[] = "BrowserFrameAndroid"; | |
| 19 | |
| 20 namespace { | |
| 21 aura::WindowTreeHostPlatform* host = nullptr; | |
|
msw
2015/11/02 21:40:01
nit: rename |global_host| or |g_host|; add a comme
Hadi
2015/11/03 18:48:47
Added a comment for this and SetHost() after discu
| |
| 22 } | |
| 23 | |
| 24 BrowserFrameAndroid::BrowserFrameAndroid(BrowserFrame* browser_frame, | |
| 25 BrowserView* browser_view) | |
| 26 : views::NativeWidgetAura(browser_frame), browser_view_(browser_view) { | |
| 27 GetNativeWindow()->SetName(kWindowName); | |
| 28 } | |
| 29 | |
| 30 // static | |
| 31 void BrowserFrameAndroid::SetHost( | |
| 32 aura::WindowTreeHostPlatform* window_tree_host) { | |
| 33 host = window_tree_host; | |
| 34 } | |
| 35 | |
| 36 /////////////////////////////////////////////////////////////////////////////// | |
| 37 // BrowserFrameAndroid, views::NativeWidgetAura overrides: | |
| 38 | |
| 39 void BrowserFrameAndroid::OnWindowDestroying(aura::Window* window) { | |
| 40 // Destroy any remaining WebContents early on. Doing so may result in | |
| 41 // calling back to one of the Views/LayoutManagers or supporting classes of | |
| 42 // BrowserView. By destroying here we ensure all said classes are valid. | |
| 43 DestroyBrowserWebContents(browser_view_->browser()); | |
| 44 NativeWidgetAura::OnWindowDestroying(window); | |
| 45 } | |
| 46 | |
| 47 void BrowserFrameAndroid::OnWindowTargetVisibilityChanged(bool visible) { | |
| 48 views::NativeWidgetAura::OnWindowTargetVisibilityChanged(visible); | |
|
msw
2015/11/02 21:40:01
nit: remove this override if it justs calls the ba
Hadi
2015/11/03 18:48:47
Done.
| |
| 49 } | |
| 50 | |
| 51 bool BrowserFrameAndroid::ShouldSaveWindowPlacement() const { | |
|
msw
2015/11/02 21:40:01
Match function def order to header decl order and
Hadi
2015/11/03 18:48:47
Done.
| |
| 52 return false; | |
| 53 } | |
| 54 | |
| 55 void BrowserFrameAndroid::GetWindowPlacement( | |
| 56 gfx::Rect* bounds, | |
| 57 ui::WindowShowState* show_state) const {} | |
| 58 | |
| 59 //////////////////////////////////////////////////////////////////////////////// | |
| 60 // BrowserFrameAndroid, NativeBrowserFrame implementation: | |
| 61 | |
| 62 views::Widget::InitParams BrowserFrameAndroid::GetWidgetParams() { | |
| 63 DCHECK(host != nullptr); | |
|
msw
2015/11/02 21:40:01
nit: DCHECK(host) should suffice
Hadi
2015/11/03 18:48:47
Done.
| |
| 64 | |
| 65 views::Widget::InitParams params; | |
| 66 params.native_widget = this; | |
| 67 params.context = host->window(); | |
| 68 return params; | |
| 69 } | |
| 70 | |
| 71 bool BrowserFrameAndroid::UseCustomFrame() const { | |
| 72 return true; | |
| 73 } | |
| 74 | |
| 75 bool BrowserFrameAndroid::UsesNativeSystemMenu() const { | |
| 76 return false; | |
| 77 } | |
| 78 | |
| 79 int BrowserFrameAndroid::GetMinimizeButtonOffset() const { | |
| 80 return 0; | |
| 81 } | |
| 82 | |
| 83 BrowserFrameAndroid::~BrowserFrameAndroid() {} | |
| OLD | NEW |