Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #include "chrome/browser/ui/views/frame/browser_frame_android.h" | |
| 6 | |
| 7 #include "chrome/browser/ui/views/frame/browser_shutdown.h" | |
| 8 #include "chrome/browser/ui/views/frame/browser_view.h" | |
| 9 #include "ui/aura/window.h" | |
| 10 #include "ui/aura/window_tree_host_platform.h" | |
| 11 | |
| 12 // A stripped version of BrowserFrameAsh. May need to add things back later. | |
| 13 | |
| 14 /////////////////////////////////////////////////////////////////////////////// | |
| 15 // BrowserFrameAndroid, public: | |
| 16 | |
| 17 // static | |
| 18 const char BrowserFrameAndroid::kWindowName[] = "BrowserFrameAndroid"; | |
| 19 | |
| 20 namespace { | |
| 21 static aura::WindowTreeHostPlatform* host = nullptr; | |
|
bshe
2015/11/02 16:05:13
This doesnt need to be static I believe.
mfomitchev
2015/11/02 16:07:22
no need for static since you are using anonymous n
Hadi
2015/11/02 16:33:55
Done.
| |
| 22 } | |
| 23 | |
| 24 BrowserFrameAndroid::BrowserFrameAndroid(BrowserFrame* browser_frame, | |
| 25 BrowserView* browser_view) | |
| 26 : views::NativeWidgetAura(browser_frame), browser_view_(browser_view) { | |
| 27 GetNativeWindow()->SetName(kWindowName); | |
| 28 } | |
| 29 | |
|
bshe
2015/11/02 16:05:13
Add comment "// static" before SetHost so it is ea
Hadi
2015/11/02 16:33:55
Done.
| |
| 30 void BrowserFrameAndroid::SetHost( | |
| 31 aura::WindowTreeHostPlatform* window_tree_host) { | |
|
mfomitchev
2015/11/02 16:07:22
nit: call this "host" so it the function signature
Hadi
2015/11/02 16:33:55
We already had the name "host", so I named this on
| |
| 32 host = window_tree_host; | |
| 33 } | |
| 34 | |
| 35 /////////////////////////////////////////////////////////////////////////////// | |
| 36 // BrowserFrameAndroid, views::NativeWidgetAura overrides: | |
| 37 | |
| 38 void BrowserFrameAndroid::OnWindowDestroying(aura::Window* window) { | |
| 39 // Destroy any remaining WebContents early on. Doing so may result in | |
| 40 // calling back to one of the Views/LayoutManagers or supporting classes of | |
| 41 // BrowserView. By destroying here we ensure all said classes are valid. | |
| 42 DestroyBrowserWebContents(browser_view_->browser()); | |
| 43 NativeWidgetAura::OnWindowDestroying(window); | |
| 44 } | |
| 45 | |
| 46 void BrowserFrameAndroid::OnWindowTargetVisibilityChanged(bool visible) { | |
| 47 views::NativeWidgetAura::OnWindowTargetVisibilityChanged(visible); | |
| 48 } | |
| 49 | |
| 50 bool BrowserFrameAndroid::ShouldSaveWindowPlacement() const { | |
| 51 return false; | |
| 52 } | |
| 53 | |
| 54 void BrowserFrameAndroid::GetWindowPlacement( | |
| 55 gfx::Rect* bounds, | |
| 56 ui::WindowShowState* show_state) const {} | |
| 57 | |
| 58 //////////////////////////////////////////////////////////////////////////////// | |
| 59 // BrowserFrameAndroid, NativeBrowserFrame implementation: | |
| 60 | |
| 61 views::Widget::InitParams BrowserFrameAndroid::GetWidgetParams() { | |
| 62 DCHECK(host != nullptr); | |
| 63 | |
| 64 views::Widget::InitParams params; | |
| 65 params.native_widget = this; | |
| 66 params.context = host->window(); | |
| 67 return params; | |
| 68 } | |
| 69 | |
| 70 bool BrowserFrameAndroid::UseCustomFrame() const { | |
| 71 return true; | |
| 72 } | |
| 73 | |
| 74 bool BrowserFrameAndroid::UsesNativeSystemMenu() const { | |
| 75 return false; | |
| 76 } | |
| 77 | |
| 78 int BrowserFrameAndroid::GetMinimizeButtonOffset() const { | |
| 79 return 0; | |
| 80 } | |
| 81 | |
| 82 BrowserFrameAndroid::~BrowserFrameAndroid() {} | |
| OLD | NEW |