Source/core/svg/animation/SVGSMILElement.h - Issue 141013017: Make sure begin and end events are dispatched for back-to-back intervals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/animation/SVGSMILElement.h

Issue 141013017: Make sure begin and end events are dispatched for back-to-back intervals (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove borked ASSERT. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/animations/multiple-begin-animation-events-expected.txt ('k') | Source/core/svg/animation/SVGSMILElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/svg/animation/SVGSMILElement.h

diff --git a/Source/core/svg/animation/SVGSMILElement.h b/Source/core/svg/animation/SVGSMILElement.h

index 5cdd1c432a318db324e857302a032acf7299f3d3..d66d5998b7bc70c65a15cdd80247343b2b65c44e 100644

--- a/Source/core/svg/animation/SVGSMILElement.h

+++ b/Source/core/svg/animation/SVGSMILElement.h

@@ -149,7 +149,13 @@ private:

void resolveInterval(bool first, SMILTime& beginResult, SMILTime& endResult) const;

SMILTime resolveActiveEnd(SMILTime resolvedBegin, SMILTime resolvedEnd) const;

SMILTime repeatingDuration() const;

- void checkRestart(SMILTime elapsed);

+ enum RestartedInterval {

+ DidNotRestartInterval,

+ DidRestartInterval

+ };

+ RestartedInterval maybeRestartInterval(SMILTime elapsed);

void beginListChanged(SMILTime eventTime);

void endListChanged(SMILTime eventTime);