Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 141013017: Make sure begin and end events are dispatched for back-to-back intervals (Closed)

Created:
6 years, 10 months ago by fs
Modified:
6 years, 10 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, pdr, Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make sure begin and end events are dispatched for back-to-back intervals When the end time of the previous interval is the same as the begin time of the new/current interval, the active state won't visibly transition Inactive -> Active (for 'begin' - the other way around for 'end') if the interval can be resolved up front (i.e. isn't event-base). Fix by having SVGSMILElement::checkRestart return a bool indicating whether an interval ended up being restarted, and then use this bool to extend the predicates looking for Inactive<->Active transitions. BUG=337724 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166625

Patch Set 1 #

Total comments: 1

Patch Set 2 : maybeRestartInterval #

Patch Set 3 : Remove borked ASSERT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -9 lines) Patch
A LayoutTests/svg/animations/multiple-begin-animation-events.html View 1 chunk +45 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/multiple-begin-animation-events-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 2 5 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 29 (0 generated)
fs
Try-bots seems to be in agony, but PTAL...
6 years, 10 months ago (2014-01-31 14:16:31 UTC) #1
pdr.
Sorry about the slow response times (most of the chrome team was on a trip ...
6 years, 10 months ago (2014-02-03 23:22:59 UTC) #2
fs
On 2014/02/03 23:22:59, pdr wrote: > Sorry about the slow response times (most of the ...
6 years, 10 months ago (2014-02-04 08:55:10 UTC) #3
fs
The CQ bit was checked by fs@opera.com
6 years, 10 months ago (2014-02-04 09:56:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/141013017/80001
6 years, 10 months ago (2014-02-04 09:56:37 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 10:08:12 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 10 months ago (2014-02-04 10:08:12 UTC) #7
fs
The CQ bit was checked by fs@opera.com
6 years, 10 months ago (2014-02-04 11:17:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/141013017/80001
6 years, 10 months ago (2014-02-04 11:17:41 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 13:56:39 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=10816
6 years, 10 months ago (2014-02-04 13:56:39 UTC) #11
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 13:56:50 UTC) #12
fs
The CQ bit was checked by fs@opera.com
6 years, 10 months ago (2014-02-04 14:21:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/141013017/80001
6 years, 10 months ago (2014-02-04 14:21:16 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 17:22:58 UTC) #15
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=10863
6 years, 10 months ago (2014-02-04 17:22:59 UTC) #16
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 10 months ago (2014-02-04 18:27:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/141013017/80001
6 years, 10 months ago (2014-02-04 18:28:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/141013017/80001
6 years, 10 months ago (2014-02-05 00:38:02 UTC) #19
fs
The CQ bit was unchecked by fs@opera.com
6 years, 10 months ago (2014-02-05 14:19:37 UTC) #20
fs
The CQ bit was checked by fs@opera.com
6 years, 10 months ago (2014-02-05 14:19:58 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/141013017/80001
6 years, 10 months ago (2014-02-05 14:20:15 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 17:34:14 UTC) #23
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=11080
6 years, 10 months ago (2014-02-05 17:34:15 UTC) #24
fs
The CQ bit was checked by fs@opera.com
6 years, 10 months ago (2014-02-06 10:33:39 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/141013017/80001
6 years, 10 months ago (2014-02-06 10:33:54 UTC) #26
fs
The CQ bit was checked by fs@opera.com
6 years, 10 months ago (2014-02-06 14:55:15 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/141013017/560001
6 years, 10 months ago (2014-02-06 14:55:27 UTC) #28
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 17:39:08 UTC) #29
Message was sent while issue was closed.
Change committed as 166625

Powered by Google App Engine
This is Rietveld 408576698