Issue 141013010: Rename bindingFoo to fooForBindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141013010: Rename bindingFoo to fooForBindings (Closed)

Created:
6 years, 11 months ago by philipj_slow

Modified:
6 years, 11 months ago

Reviewers:
tkent

CC:
blink-reviews, arv+blink, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rename bindingFoo to fooForBindings Switch to the majority convention so that no one needs to investigate which to use, as in https://codereview.chromium.org/141363002/ BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165287

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	Source/core/dom/Element.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Node.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Node.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/shadow/ShadowRoot.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/shadow/ShadowRoot.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/shadow/ShadowRoot.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/141013010/1

6 years, 11 months ago (2014-01-17 06:16:07 UTC) #3

Message was sent while issue was closed.

Change committed as 165287

Expand Messages | Collapse Messages