Report parse error for WebM clusters missing a timecode

Report parse error for WebM clusters missing a timecode

Replaces a DCHECK with parse error when parsing a WebM
cluster that has no timecode. This supplements the existing
WebMClusterParser::OnBlock() logic that similarly indicates
parse error when processing blocks. However, if there were
no blocks in the cluster, then the DCHECK could have been
hit if there were no timecode.

R=acolwell@chromium.org
BUG=335344
TEST=(local Linux) All media_unittests pass including the new ones

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245608

[wolenetz, 2014-01-17 01:57:07]

PTAL. cluster_timecode is mandatory for every Matroska cluster, so let's issue
parse failure instead of silence in Release builds or DCHECKS in debug builds
when this is violated.

[acolwell GONE FROM CHROMIUM, 2014-01-17 16:34:25]

lgtm % nits

https://codereview.chromium.org/141013008/diff/1/media/webm/webm_cluster_pars...
File media/webm/webm_cluster_parser_unittest.cc (right):

https://codereview.chromium.org/141013008/diff/1/media/webm/webm_cluster_pars...
media/webm/webm_cluster_parser_unittest.cc:532: int size = sizeof(kBuffer);
nit: just inline this since size isn't used anywhere else and there is space on
the Parse() line.

https://codereview.chromium.org/141013008/diff/1/media/webm/webm_cluster_pars...
media/webm/webm_cluster_parser_unittest.cc:543: int size = sizeof(kBuffer);
ditto.

[wolenetz, 2014-01-17 18:47:55]

Thanks. I'll CQ this shortly.

https://codereview.chromium.org/141013008/diff/1/media/webm/webm_cluster_pars...
File media/webm/webm_cluster_parser_unittest.cc (right):

https://codereview.chromium.org/141013008/diff/1/media/webm/webm_cluster_pars...
media/webm/webm_cluster_parser_unittest.cc:532: int size = sizeof(kBuffer);
On 2014/01/17 16:34:26, acolwell wrote:
> nit: just inline this since size isn't used anywhere else and there is space
on
> the Parse() line.

Done.

https://codereview.chromium.org/141013008/diff/1/media/webm/webm_cluster_pars...
media/webm/webm_cluster_parser_unittest.cc:543: int size = sizeof(kBuffer);
On 2014/01/17 16:34:26, acolwell wrote:
> ditto.

Done.

[commit-bot: I haz the power, 2014-01-17 18:52:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wolenetz@chromium.org/141013008/150001

[commit-bot: I haz the power, 2014-01-17 20:38:56]

Change committed as 245608