Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410123005: dart2js cps: Remove unneeded bailout on captured loop variables. (Closed)

Created:
5 years, 1 month ago by asgerf
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Remove unneeded bailout on captured loop variables. The analysis of try-boxed variables reused some code from the old dart2dart CPS backend, which had bailouts for code that is handled just fine in the dart2js CPS backend. R=karlklose@google.com, kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/695bdf4fa365fc84ef4dda9e0fde84b58772ca9b Committed: https://github.com/dart-lang/sdk/commit/0c25cd27ac3eb1f0f1f517a5f70e9f73f0f3125c

Patch Set 1 #

Patch Set 2 : More status file updates #

Patch Set 3 : Revert + Unrevert #

Patch Set 4 : Remove show clause for DartCapturedVariables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -41 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 6 chunks +9 lines, -37 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
asgerf
5 years, 1 month ago (2015-10-27 10:34:35 UTC) #2
Kevin Millikin (Google)
Yes, nice. LGTM.
5 years, 1 month ago (2015-10-27 10:47:22 UTC) #4
asgerf
Committed patchset #2 (id:20001) manually as 695bdf4fa365fc84ef4dda9e0fde84b58772ca9b (presubmit successful).
5 years, 1 month ago (2015-10-27 10:51:33 UTC) #5
karlklose
LGTM.
5 years, 1 month ago (2015-10-27 11:05:14 UTC) #6
asgerf
5 years, 1 month ago (2015-10-27 12:01:16 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
0c25cd27ac3eb1f0f1f517a5f70e9f73f0f3125c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698