Issue 14101006: Convert an OS_SUN use to OS_SOLARIS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14101006: Convert an OS_SUN use to OS_SOLARIS. (Closed)

Created:
7 years, 8 months ago by Scott Hess - ex-Googler

Modified:
7 years, 8 months ago

Reviewers:
M-A Ruel, robertphillips

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert an OS_SUN use to OS_SOLARIS. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194681

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	PRESUBMIT.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	skia/ext/platform_device.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

From https://codereview.chromium.org/12825014/ On 2013/04/16 23:09:45, robertphillips wrote: > lgtm. Specifically w.r.t. the changes in skia/ext/platform_device.h. ...

7 years, 8 months ago (2013-04-16 23:35:36 UTC) #1

Scott Hess - ex-Googler

Still need OWNERS LGTM robertphillips! thx.

7 years, 8 months ago (2013-04-17 19:12:07 UTC) #3

Scott Hess - ex-Googler

7 years, 8 months ago (2013-04-17 21:19:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r194681 (presubmit successful).

Expand Messages | Collapse Messages