Issue 14101003: Add DEPS file for googleurl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14101003: Add DEPS file for googleurl. (Closed)

Created:
7 years, 8 months ago by brettw

Modified:
7 years, 8 months ago

Reviewers:
eroman

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add DEPS file for googleurl. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193447

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	A	url/DEPS	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eroman

7 years, 8 months ago (2013-04-10 21:06:01 UTC) #3

lgtm


On Wed, Apr 10, 2013 at 1:30 PM, <brettw@chromium.org> wrote:

> Reviewers: eroman,
>
> Description:
> Add DEPS file for googleurl.
>
> Please review this at
https://codereview.chromium.**org/14101003/<https://codereview.chromium.org/1...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>   A     url/DEPS
>
>
> Index: url/DEPS
> ==============================**==============================**=======
> --- url/DEPS    (revision 0)
> +++ url/DEPS    (revision 0)
> @@ -0,0 +1,4 @@
> +include_rules = [
> +  # TODO(brettw) erase these, just temporary until this code is done.
> +  "+unicode",
> +]
>
>
>

Expand Messages | Collapse Messages