Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 1410093009: build: Add libffi as a build dependency on linux. (Closed)

Created:
5 years, 1 month ago by reveman
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

build: Add libffi as a build dependency on linux. libffi is already a run-time dependency as libgobject depends on it. BUG=549782 Committed: https://crrev.com/dd26069ac26c43fcb8628e61eb6d45cc1f696f01 Cr-Commit-Position: refs/heads/master@{#358662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M build/install-build-deps.sh View 2 chunks +14 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410093009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410093009/1
5 years, 1 month ago (2015-11-09 18:07:16 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-09 18:18:10 UTC) #4
reveman
5 years, 1 month ago (2015-11-09 19:28:48 UTC) #6
Nico
lgtm
5 years, 1 month ago (2015-11-09 21:21:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410093009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410093009/1
5 years, 1 month ago (2015-11-09 21:29:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 21:39:28 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 21:40:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd26069ac26c43fcb8628e61eb6d45cc1f696f01
Cr-Commit-Position: refs/heads/master@{#358662}

Powered by Google App Engine
This is Rietveld 408576698