third_party/WebKit/Source/core/frame/LocalFrame.cpp - Issue 1410093006: Exempt about: URLs from self-reference check for nested frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 1410093006: Exempt about: URLs from self-reference check for nested frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/frames/srcdoc/srcdoc-deep-nested-frames.html ('K') | « third_party/WebKit/LayoutTests/fast/frames/srcdoc/srcdoc-deep-nested-frames.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

index 16bb9bbbca38286bc035ee4e0b8247c36dd9b10b..6058f487bdcc8a948b85af45099699891980db71 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

@@ -754,6 +754,10 @@ EphemeralRange LocalFrame::rangeForPoint(const IntPoint& framePoint)

bool LocalFrame::isURLAllowed(const KURL& url) const

{

+ // Exempt about URLs from self-reference check.

dcheng 2015/11/18 03:23:19 Nit: s/about/about:/

Xiaocheng 2015/11/18 10:26:00 Done.

+ if (url.protocolIsAbout())

+ return true;

// We allow one level of self-reference because some sites depend on that,

// but we don't allow more than one.

bool foundSelfReference = false;