third_party/WebKit/LayoutTests/fast/frames/srcdoc/srcdoc-deep-nested-frames.html - Issue 1410093006: Exempt about: URLs from self-reference check for nested frames

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/frames/srcdoc/srcdoc-deep-nested-frames.html

Issue 1410093006: Exempt about: URLs from self-reference check for nested frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/frames/deep-nested-about-blank.html ('K') | « third_party/WebKit/LayoutTests/fast/frames/deep-nested-about-blank.html ('k') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('j') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <script src="../../../resources/testharness.js"></script>

	4 <script src="../../../resources/testharnessreport.js"></script>

	5

	6 <iframe id="frame1" srcdoc='1

	7 <iframe id="frame2" srcdoc="2

	8 <iframe id=frame3 srcdoc=3></iframe>

	9 "></iframe>

	10 '></iframe>

	11

	12 <script>

	13 frame1.onload = function() {

	14 var frame2 = frame1.contentDocument.getElementById("frame2");

	15 var frame3 = frame2.contentDocument.getElementById("frame3");

	16 test(function() {assert_not_equals(frame3.contentDocument, null)}, "deep neste d frames should still have non-null content documents.");
	dcheng 2015/11/18 03:23:18 Nit: "nested srcdocs should not be blocked as self Nit: "nested srcdocs should not be blocked as self-referential frames." might be more descriptive. Xiaocheng 2015/11/18 10:26:00 Done. Show quoted text On 2015/11/18 03:23:18, dcheng wrote: > Nit: "nested srcdocs should not be blocked as self-referential frames." might be > more descriptive. Done.
	17 };

	18 </script>

	19

	20

OLD	NEW