Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1410073009: Use standard true and false to replace 'TRUE' and 'FALSE' in pdfium_test (Closed)

Created:
5 years, 1 month ago by jun_fang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use standard true and false to replace 'TRUE' and 'FALSE' in pdfium_test BUG=446715 TBR=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/71fca3fffc40f63b28c0085add17ac73b5a066ef

Patch Set 1 : Replace TRUE and FALSE. #

Patch Set 2 : Remove compiling warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/parser_int.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M samples/pdfium_test.cc View 5 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
jun_fang
Committed patchset #2 (id:20001) manually as 71fca3fffc40f63b28c0085add17ac73b5a066ef (tree was closed).
5 years, 1 month ago (2015-11-02 07:03:28 UTC) #3
Tom Sepez
5 years, 1 month ago (2015-11-02 17:41:21 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698