core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp - Issue 1410073007: Merge to XFA: Revert "Revert "Add type cast definitions for CPDF_Reference.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

Issue 1410073007: Merge to XFA: Revert "Revert "Add type cast definitions for CPDF_Reference."" (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

index 606bd0f569c1e8b7cfa2d94fc2c86568f8a5a593..e1e60ecae3432667cc77212e8f5971d2985a42ba 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

@@ -381,8 +381,7 @@ CFX_ByteTextBuf& operator<<(CFX_ByteTextBuf& buf, const CPDF_Object* pObj) {

break;

}

case PDFOBJ_REFERENCE: {

- CPDF_Reference* p = (CPDF_Reference*)pObj;

- buf << " " << p->GetRefObjNum() << FX_BSTRC(" 0 R ");

+ buf << " " << pObj->AsReference()->GetRefObjNum() << FX_BSTRC(" 0 R ");

break;

}

case PDFOBJ_ARRAY: {

« no previous file with comments | « core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp ('k') | core/src/fpdfdoc/doc_form.cpp » ('j') | fpdfsdk/src/fpdfppo.cpp » ('J')