Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: src/api.cc

Issue 1410073005: Replace FunctionToLocal with CallableToLocal (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.h ('k') | test/cctest/compiler/test-run-jscalls.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 4f3947fb3879531c7d31014bd596729d340033f5..8bfc8f0e8214ebb446f41c44c5189c90ffeabdf0 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -2009,7 +2009,7 @@ MaybeLocal<Function> ScriptCompiler::CompileFunctionInContext(
nullptr).ToHandle(&result);
RETURN_ON_FAILED_EXECUTION(Function);
RETURN_ESCAPED(
- Utils::FunctionToLocal(i::Handle<i::JSFunction>::cast(result)));
+ Utils::CallableToLocal(i::Handle<i::JSFunction>::cast(result)));
}
@@ -4540,7 +4540,7 @@ Local<v8::Value> Function::GetBoundFunction() const {
i::BindingsArray::cast(func->function_bindings()));
i::Handle<i::Object> original(bound_args->bound_function(),
func->GetIsolate());
- return Utils::FunctionToLocal(i::Handle<i::JSFunction>::cast(original));
+ return Utils::CallableToLocal(i::Handle<i::JSFunction>::cast(original));
}
@@ -7768,7 +7768,7 @@ MaybeLocal<Value> Debug::GetMirror(Local<Context> context,
i::Handle<i::JSObject> debug(isolate_debug->debug_context()->global_object());
auto name = isolate->factory()->NewStringFromStaticChars("MakeMirror");
auto fun_obj = i::Object::GetProperty(debug, name).ToHandleChecked();
- auto v8_fun = Utils::FunctionToLocal(i::Handle<i::JSFunction>::cast(fun_obj));
+ auto v8_fun = Utils::CallableToLocal(i::Handle<i::JSFunction>::cast(fun_obj));
const int kArgc = 1;
v8::Local<v8::Value> argv[kArgc] = {obj};
Local<Value> result;
« no previous file with comments | « src/api.h ('k') | test/cctest/compiler/test-run-jscalls.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698