Issue 1410073005: Replace FunctionToLocal with CallableToLocal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1410073005: Replace FunctionToLocal with CallableToLocal (Closed)

Created:
5 years, 1 month ago by jochen (gone - plz use gerrit)

Modified:
5 years, 1 month ago

Reviewers:
Toon Verwaest

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Replace FunctionToLocal with CallableToLocal Because that's what it actually does R=verwaest@chromium.org BUG=none LOG=n Committed: https://crrev.com/618178fc9fd5054137f6cb381f9c1f3653180986 Cr-Commit-Position: refs/heads/master@{#31563}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	src/api.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/api.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	test/cctest/compiler/test-run-jscalls.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-alloc.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410073005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410073005/1

5 years, 1 month ago (2015-10-26 13:02:14 UTC) #4

commit-bot: I haz the power

5 years, 1 month ago (2015-10-26 13:37:15 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/618178fc9fd5054137f6cb381f9c1f3653180986
Cr-Commit-Position: refs/heads/master@{#31563}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages