Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1410073004: [unittests] Fix build/namespaces style guide violation. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[unittests] Fix build/namespaces style guide violation. From the Google C++ style guide: "You may not use a using-directive to make all names from a namespace available". This would be covered by presubmit linter checks if build/namespaces were not blacklisted. R=bmeurer@chromium.org Committed: https://crrev.com/d8ceb9cb58932dfe52cdd4fe7331d1e0328d58a9 Cr-Commit-Position: refs/heads/master@{#31565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M test/unittests/compiler/typer-unittest.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 1 month ago (2015-10-26 13:01:17 UTC) #1
Benedikt Meurer
lgtm
5 years, 1 month ago (2015-10-26 13:21:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410073004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410073004/1
5 years, 1 month ago (2015-10-26 13:29:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 13:46:37 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 13:47:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8ceb9cb58932dfe52cdd4fe7331d1e0328d58a9
Cr-Commit-Position: refs/heads/master@{#31565}

Powered by Google App Engine
This is Rietveld 408576698