Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: mojo/public/dart/mojo/lib/src/message.dart

Issue 1410053002: Dart: Uses a pre-allocated buffer for message pipe query and read. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/dart/mojo/lib/src/codec.dart ('k') | mojo/public/dart/mojo/lib/src/message_pipe.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/dart/mojo/lib/src/message.dart
diff --git a/mojo/public/dart/mojo/lib/src/message.dart b/mojo/public/dart/mojo/lib/src/message.dart
index 55feee3b70522d5383802490f2b25b7c23a12624..d617d1e035629ea3630b8c8d834c43bb2689ea34 100644
--- a/mojo/public/dart/mojo/lib/src/message.dart
+++ b/mojo/public/dart/mojo/lib/src/message.dart
@@ -77,10 +77,11 @@ class MessageHeader {
class Message {
final ByteData buffer;
final List<core.MojoHandle> handles;
- int get numHandles => (handles == null) ? 0 : handles.length;
- Message(this.buffer, this.handles);
+ final dataLength;
+ final handlesLength;
+ Message(this.buffer, this.handles, this.dataLength, this.handlesLength);
String toString() =>
- "Message(numBytes=${buffer.lengthInBytes}, numHandles=${numHandles})";
+ "Message(numBytes=${dataLength}, numHandles=${handlesLength})";
}
class ServiceMessage extends Message {
@@ -88,7 +89,8 @@ class ServiceMessage extends Message {
Message _payload;
ServiceMessage(Message message, this.header)
- : super(message.buffer, message.handles);
+ : super(message.buffer, message.handles, message.dataLength,
+ message.handlesLength);
ServiceMessage.fromMessage(Message message)
: this(message, new MessageHeader.fromMessage(message));
@@ -96,7 +98,8 @@ class ServiceMessage extends Message {
Message get payload {
if (_payload == null) {
var truncatedBuffer = new ByteData.view(buffer.buffer, header.size);
- _payload = new Message(truncatedBuffer, handles);
+ _payload = new Message(
+ truncatedBuffer, handles, dataLength - header.size, handlesLength);
}
return _payload;
}
« no previous file with comments | « mojo/public/dart/mojo/lib/src/codec.dart ('k') | mojo/public/dart/mojo/lib/src/message_pipe.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698