ash/system/chromeos/network/vpn_delegate.h - Issue 1410033002: Fix occasional crash in ~VPNListView during shell destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/chromeos/network/vpn_delegate.h

Issue 1410033002: Fix occasional crash in ~VPNListView during shell destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable DCHECK in VPNDelegate; handle possible non-existence of VPNDelegate during VPNListView dest… Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/system/chromeos/network/vpn_delegate.h

diff --git a/ash/system/chromeos/network/vpn_delegate.h b/ash/system/chromeos/network/vpn_delegate.h

index aaf76a3b145ab3341c310d10413a4bb166eca334..fd6fe72972e8e88fd3cf42b635291a651ed0f9c3 100644

--- a/ash/system/chromeos/network/vpn_delegate.h

+++ b/ash/system/chromeos/network/vpn_delegate.h

@@ -91,7 +91,7 @@ class ASH_EXPORT VPNDelegate {

void NotifyObservers();

private:

- base::ObserverList<Observer, true> observer_list_;

+ base::ObserverList<Observer> observer_list_;

DISALLOW_COPY_AND_ASSIGN(VPNDelegate);

};

« no previous file with comments | « no previous file | ash/system/chromeos/network/vpn_list_view.cc » ('j') | no next file with comments »