Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1410023015: Split default parameters that require destructuring into their own file (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Split default parameters that require destructuring into their own file This allows testing the configuration where --harmony-default-parameters is passed without --harmony-destructuring. R=rossberg@chromium.org BUG=v8:2160 LOG=n Committed: https://crrev.com/7b556cd24f13ffe0d4c42f0ab0951d72bccc9135 Cr-Commit-Position: refs/heads/master@{#31863}

Patch Set 1 #

Patch Set 2 : Add missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -95 lines) Patch
M test/mjsunit/harmony/default-parameters.js View 4 chunks +1 line, -95 lines 0 comments Download
A test/mjsunit/harmony/default-parameters-destructuring.js View 1 1 chunk +112 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
adamk
5 years, 1 month ago (2015-11-06 01:08:30 UTC) #1
adamk
My thought is that this might be useful if we wanted to ship default parameters ...
5 years, 1 month ago (2015-11-06 01:08:52 UTC) #2
rossberg
lgtm
5 years, 1 month ago (2015-11-06 13:01:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410023015/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410023015/20001
5 years, 1 month ago (2015-11-06 15:47:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-06 15:48:48 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 15:49:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b556cd24f13ffe0d4c42f0ab0951d72bccc9135
Cr-Commit-Position: refs/heads/master@{#31863}

Powered by Google App Engine
This is Rietveld 408576698