Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 1410023012: Fix broken logic for search chip icon spacing. (Closed)

Created:
5 years, 1 month ago by Evan Stade
Modified:
5 years, 1 month ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix broken logic for search chip icon spacing. The logic got switched around too many times in 81a623407a261 and apparently I forgot to verify the final version worked correctly. BUG=505953 Committed: https://crrev.com/bd97d4cc25ef8d5132d5fbf2d960e7cc802a1444 Cr-Commit-Position: refs/heads/master@{#356723}

Patch Set 1 #

Patch Set 2 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Evan Stade
5 years, 1 month ago (2015-10-29 00:22:36 UTC) #2
Peter Kasting
RS LGTM, I did not think through the logic here to verify the correctness :)
5 years, 1 month ago (2015-10-29 00:26:01 UTC) #3
Evan Stade
On 2015/10/29 00:26:01, Peter Kasting wrote: > RS LGTM, I did not think through the ...
5 years, 1 month ago (2015-10-29 00:28:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410023012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410023012/20001
5 years, 1 month ago (2015-10-29 00:29:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-29 01:23:29 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 01:24:37 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd97d4cc25ef8d5132d5fbf2d960e7cc802a1444
Cr-Commit-Position: refs/heads/master@{#356723}

Powered by Google App Engine
This is Rietveld 408576698