Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1410023006: [turbofan] Fix JSInliner strong mode bailout. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix JSInliner strong mode bailout. This moves the bailout point in the JSInliner up to a point where it is still allowed to decide not to inline. Once the inlining decision has been recorded with CompilationInfo::AddInlinedFunction, we should not abort anymore. R=jarin@chromium.org Committed: https://crrev.com/4054961fa43c5ad85b25badb63c9ed7a93d1fafa Cr-Commit-Position: refs/heads/master@{#31469}

Patch Set 1 #

Patch Set 2 : Fix signed versus unsigned. #

Total comments: 2

Patch Set 3 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M src/compiler/js-inlining.cc View 1 2 2 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-22 09:38:11 UTC) #1
Jarin
lgtm (once the signedness problem is resolved)
5 years, 2 months ago (2015-10-22 09:42:17 UTC) #2
Jarin
still lgtm. https://codereview.chromium.org/1410023006/diff/20001/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (left): https://codereview.chromium.org/1410023006/diff/20001/src/compiler/js-inlining.cc#oldcode405 src/compiler/js-inlining.cc:405: size_t const inlinee_formal_parameters = start->op()->ValueOutputCount() - 3; ...
5 years, 2 months ago (2015-10-22 10:03:09 UTC) #3
Michael Starzinger
https://codereview.chromium.org/1410023006/diff/20001/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (left): https://codereview.chromium.org/1410023006/diff/20001/src/compiler/js-inlining.cc#oldcode405 src/compiler/js-inlining.cc:405: size_t const inlinee_formal_parameters = start->op()->ValueOutputCount() - 3; On 2015/10/22 ...
5 years, 2 months ago (2015-10-22 10:35:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410023006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410023006/40001
5 years, 2 months ago (2015-10-22 11:40:27 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-22 11:41:58 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 11:42:26 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4054961fa43c5ad85b25badb63c9ed7a93d1fafa
Cr-Commit-Position: refs/heads/master@{#31469}

Powered by Google App Engine
This is Rietveld 408576698