Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1410023002: [SystemWebViewShell] Fix WebViewShell manifest. (Closed)

Created:
5 years, 2 months ago by timvolodine
Modified:
5 years, 2 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org, the real yoland
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SystemWebViewShell] Fix WebViewShell manifest. The WebViewShell should not have BaseChromiumApplication as name. The breaking change was introduced in crrev.com/1402833002, this patch reverts it. Note: deriving from BaseChromiumApplication has the effect that some chromium specific code is initialized that is not normally initialized in apps. BUG= TBR=torne@chromium.org Committed: https://crrev.com/5f4a677bdba5250ff3ed3fc829975cbe489d3d24 Cr-Commit-Position: refs/heads/master@{#354514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M android_webview/tools/WebViewShell/AndroidManifest.xml View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
timvolodine
5 years, 2 months ago (2015-10-16 15:03:34 UTC) #2
Torne
lgtm
5 years, 2 months ago (2015-10-16 15:07:36 UTC) #3
timvolodine
On 2015/10/16 15:07:36, Torne wrote: > lgtm Note: deriving from BaseChromiumApplication has the effect that ...
5 years, 2 months ago (2015-10-16 15:10:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410023002/1
5 years, 2 months ago (2015-10-16 15:12:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 15:18:58 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 15:19:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f4a677bdba5250ff3ed3fc829975cbe489d3d24
Cr-Commit-Position: refs/heads/master@{#354514}

Powered by Google App Engine
This is Rietveld 408576698