Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1410003002: [turbofan] Remove locally constructed simplified builders. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove locally constructed simplified builders. This removes all locally constructed SimplifiedOperatorBuilder instances and uses the one passed along the JSGraph. It ensures that the correct zone is used to allocate operators, no matter where the reducer is used. R=bmeurer@chromium.org Committed: https://crrev.com/dbae315a102506b743269c1d9939c617a067ae20 Cr-Commit-Position: refs/heads/master@{#31355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -40 lines) Patch
M src/compiler/js-builtin-reducer.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/compiler/js-type-feedback.h View 4 chunks +1 line, -4 lines 0 comments Download
M src/compiler/js-type-feedback-lowering.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/compiler/js-type-feedback-lowering.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 4 chunks +2 lines, -3 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +6 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/js-type-feedback-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-16 13:52:56 UTC) #1
Benedikt Meurer
lgtm
5 years, 2 months ago (2015-10-17 04:42:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410003002/1
5 years, 2 months ago (2015-10-19 07:43:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 08:05:13 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 08:05:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbae315a102506b743269c1d9939c617a067ae20
Cr-Commit-Position: refs/heads/master@{#31355}

Powered by Google App Engine
This is Rietveld 408576698