Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: src/isolate.h

Issue 1409993012: Add {CancelableTaskManager} to handle {Cancelable} concurrent tasks. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/scavenge-job.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index 5abbc75df9f882e7b6af299c9bacbb6aa1c6ea0c..6a20c3e916633af6dca677d5cb22907da205ffa9 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -1093,8 +1093,9 @@ class Isolate {
FutexWaitListNode* futex_wait_list_node() { return &futex_wait_list_node_; }
- void RegisterCancelableTask(Cancelable* task);
- void RemoveCancelableTask(Cancelable* task);
+ CancelableTaskManager* cancelable_task_manager() {
+ return cancelable_task_manager_;
+ }
interpreter::Interpreter* interpreter() const { return interpreter_; }
@@ -1338,7 +1339,7 @@ class Isolate {
FutexWaitListNode futex_wait_list_node_;
- std::set<Cancelable*> cancelable_tasks_;
+ CancelableTaskManager* cancelable_task_manager_;
v8::Isolate::AbortOnUncaughtExceptionCallback
abort_on_uncaught_exception_callback_;
« no previous file with comments | « src/heap/scavenge-job.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698