Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 the V8 project authors. All rights reserved. | 1 // Copyright 2015 the V8 project authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "src/cancelable-task.h" | 5 #include "src/cancelable-task.h" |
| 6 | 6 |
| 7 #include "src/base/platform/platform.h" | 7 #include "src/base/platform/platform.h" |
| 8 #include "src/isolate.h" | 8 #include "src/isolate.h" |
| 9 | 9 |
| 10 namespace v8 { | 10 namespace v8 { |
| 11 namespace internal { | 11 namespace internal { |
| 12 | 12 |
| 13 | 13 |
| 14 Cancelable::Cancelable(Isolate* isolate) | 14 Cancelable::Cancelable(Isolate* isolate) |
| 15 : isolate_(isolate), is_cancelled_(false) { | 15 : isolate_(isolate), status_(kWaiting) { |
|
Hannes Payer (out of office)
2015/11/04 23:19:00
atomic set?
| |
| 16 isolate->RegisterCancelableTask(this); | 16 isolate->RegisterCancelableTask(this); |
| 17 } | 17 } |
| 18 | 18 |
| 19 | 19 |
| 20 Cancelable::~Cancelable() { | 20 Cancelable::~Cancelable() { |
| 21 if (!is_cancelled_) { | 21 if (CanRun() || IsRunning() || IsCanceled()) { |
|
Hannes Payer (out of office)
2015/11/04 23:19:00
Why would you CanRun here?
| |
| 22 // Get exclusive access here to avoid a race with the isolate when calling | |
| 23 // {CancelForShutdown}. | |
| 22 isolate_->RemoveCancelableTask(this); | 24 isolate_->RemoveCancelableTask(this); |
| 23 } | 25 } |
| 24 } | 26 } |
| 25 | 27 |
| 26 | 28 |
| 27 } // namespace internal | 29 } // namespace internal |
| 28 } // namespace v8 | 30 } // namespace v8 |
| OLD | NEW |