src/log.cc - Issue 1409993006: Fix external callback logging in profiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log.cc

Issue 1409993006: Fix external callback logging in profiler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/log.cc

diff --git a/src/log.cc b/src/log.cc

index ea69fb4bee3e71cecb6ae6a38f8dba69445b3657..a10d9621d32a7ea721e9599fc42ec67cca33faf2 100644

--- a/src/log.cc

+++ b/src/log.cc

@@ -1497,7 +1497,11 @@ void Logger::TickEvent(TickSample* sample, bool overflow) {

msg.Append(",%ld", static_cast<int>(timer_.Elapsed().InMicroseconds()));

if (sample->has_external_callback) {

msg.Append(",1,");

+#if USES_FUNCTION_DESCRIPTORS

+ msg.AppendAddress(*FUNCTION_ENTRYPOINT_ADDRESS(sample->external_callback));

+#else

msg.AppendAddress(sample->external_callback);

+#endif

} else {

msg.Append(",0,");

msg.AppendAddress(sample->tos);

« no previous file with comments | « src/globals.h ('k') | src/vm-state.h » ('j') | no next file with comments »