Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 1409993006: Fix external callback logging in profiler. (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix external callback logging in profiler. For platforms that use function descriptors (currently AIX and PPC64BE), log an external callback's entrypoint address rather than its function descriptor address. This allows proper lookup in the tick processor's symbol table. R=jkummerow@chromium.org, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/2bd5914bc3ae8c01c115f0386ae91c9f341c7ccb Cr-Commit-Position: refs/heads/master@{#31633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M src/frames.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/globals.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/log.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/vm-state.h View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
This fix is part of the solution for an issue found in node.js testing. (see ...
5 years, 1 month ago (2015-10-27 18:08:31 UTC) #1
Jakob Kummerow
lgtm
5 years, 1 month ago (2015-10-28 09:21:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409993006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409993006/1
5 years, 1 month ago (2015-10-28 13:17:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 13:42:26 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 13:42:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bd5914bc3ae8c01c115f0386ae91c9f341c7ccb
Cr-Commit-Position: refs/heads/master@{#31633}

Powered by Google App Engine
This is Rietveld 408576698