bench/ETCBitmapBench.cpp - Issue 1409993003: Misc: Don't run etc1 bench with invalid image and fix VS2015 build warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bench/ETCBitmapBench.cpp

Issue 1409993003: Misc: Don't run etc1 bench with invalid image and fix VS2015 build warning (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: bench/ETCBitmapBench.cpp

diff --git a/bench/ETCBitmapBench.cpp b/bench/ETCBitmapBench.cpp

index d4068ca88e069e575c04185dc2648cb8eb58262d..fe6fe06057ec1d1ea0ba87bb0796ad31b7b2da56 100644

--- a/bench/ETCBitmapBench.cpp

+++ b/bench/ETCBitmapBench.cpp

@@ -123,7 +123,7 @@ public:

: fDecompress(decompress), fBackend(backend) { }

bool isSuitableFor(Backend backend) override {

- return backend == this->fBackend;

+ return SkToBool(fImage) && backend == this->fBackend;

}

protected:

« no previous file with comments | « no previous file | tools/sk_tool_utils.cpp » ('j') | no next file with comments »