Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1409973004: Fix Mac after FileOperationResult change (Closed)

Created:
5 years, 1 month ago by scottmg
Modified:
5 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Fix Mac after FileOperationResult change Oops, forgot to test Mac, sorry. R=mark@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/80f50467c301d9ef0c2e093c4c004c59dfe30cea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M util/file/file_io_posix.cc View 2 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
Looking through uses of ReadFile() and WriteFile() now.
5 years, 1 month ago (2015-10-22 21:05:14 UTC) #1
Mark Mentovai
LGTM
5 years, 1 month ago (2015-10-22 21:15:13 UTC) #2
scottmg
5 years, 1 month ago (2015-10-22 21:17:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
80f50467c301d9ef0c2e093c4c004c59dfe30cea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698