Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1409933012: MD Downloads: re-jigger the order of i18n processing (Closed)

Created:
5 years, 1 month ago by Dan Beam
Modified:
5 years, 1 month ago
Reviewers:
michaelpg
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: re-jigger the order of i18n processing The non-vulcanized version was racey (not loading translations sometimes). R=michaelpg@chromium.org BUG=none Committed: https://crrev.com/0892bceb3b837c01ac1b477cf61312f2c52fb2df Cr-Commit-Position: refs/heads/master@{#359004}

Patch Set 1 : mac vulcanize #

Total comments: 2

Patch Set 2 : i18n_setup.html #

Patch Set 3 : grd + c++ funkiness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/action_service.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/crisper.js View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/md_downloads/downloads.html View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/i18n.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
A + chrome/browser/resources/md_downloads/i18n_setup.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/manager.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Dan Beam
5 years, 1 month ago (2015-11-06 22:48:21 UTC) #4
michaelpg
lgtm w/ suggestion https://codereview.chromium.org/1409933012/diff/40001/chrome/browser/resources/md_downloads/downloads.html File chrome/browser/resources/md_downloads/downloads.html (right): https://codereview.chromium.org/1409933012/diff/40001/chrome/browser/resources/md_downloads/downloads.html#newcode36 chrome/browser/resources/md_downloads/downloads.html:36: <link rel="import" href="chrome://downloads/i18n.html"> perhaps rename now ...
5 years, 1 month ago (2015-11-09 20:25:47 UTC) #5
Dan Beam
https://codereview.chromium.org/1409933012/diff/40001/chrome/browser/resources/md_downloads/downloads.html File chrome/browser/resources/md_downloads/downloads.html (right): https://codereview.chromium.org/1409933012/diff/40001/chrome/browser/resources/md_downloads/downloads.html#newcode36 chrome/browser/resources/md_downloads/downloads.html:36: <link rel="import" href="chrome://downloads/i18n.html"> On 2015/11/09 20:25:47, michaelpg wrote: > ...
5 years, 1 month ago (2015-11-11 00:03:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409933012/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409933012/80001
5 years, 1 month ago (2015-11-11 00:51:11 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 1 month ago (2015-11-11 01:37:55 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 01:38:38 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0892bceb3b837c01ac1b477cf61312f2c52fb2df
Cr-Commit-Position: refs/heads/master@{#359004}

Powered by Google App Engine
This is Rietveld 408576698