Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1409933004: dart2js: Fix marking of boxed loop variables. (Closed)

Created:
5 years, 2 months ago by asgerf
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 2 chunks +19 lines, -15 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
Fixes an issue with boxed loop variables, see also: https://codereview.chromium.org/1412663006/
5 years, 2 months ago (2015-10-23 09:38:29 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
5 years, 2 months ago (2015-10-23 15:15:06 UTC) #3
asgerf
5 years, 2 months ago (2015-10-23 15:40:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7c09a56c76f9223f7163abdabdd32b1a22bb195d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698