Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 140993006: [NaCl SDK Docs] Check in the generated NaCl SDK Documentation. (Closed)

Created:
6 years, 11 months ago by binji
Modified:
6 years, 11 months ago
Reviewers:
Sam Clegg, Andy
CC:
chromium-reviews, extensions-reviews_chromium.org, scheib+watch_chromium.org, Sam Clegg, chromium-apps-reviews_chromium.org, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[NaCl SDK Docs] Check in the generated NaCl SDK Documentation. This is necessary so that the Chromesite server can poll for changes and automatically update. I can't upload the full docs/images to Rietveld, so this review will just be empty and I'll manually commit. BUG=none R=awatson@chromium.org, sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246665

Patch Set 1 #

Patch Set 2 : trying again #

Patch Set 3 : one more time... #

Patch Set 4 : try without pepper_{dev,beta,stable} #

Total comments: 2

Patch Set 5 : empty CL, with whitespace change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M native_client_sdk/src/doc/README View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
binji
6 years, 11 months ago (2014-01-21 22:49:26 UTC) #1
Andy
LGTM. A couple of minor comments inline. I think there will be a few issues ...
6 years, 11 months ago (2014-01-22 00:24:13 UTC) #2
binji
OK, I'm just going to leave this CL empty and commit everything manually. Sam, can ...
6 years, 11 months ago (2014-01-22 20:03:43 UTC) #3
Sam Clegg
lgtm
6 years, 11 months ago (2014-01-22 20:52:59 UTC) #4
binji
6 years, 11 months ago (2014-01-23 19:28:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r246665.

Powered by Google App Engine
This is Rietveld 408576698