Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: base/version.cc

Issue 14099010: Move Version to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/version.h ('k') | chrome/browser/component_updater/flash_component_installer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/version.h" 5 #include "base/version.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 for (size_t i = count; i < components2.size(); ++i) { 68 for (size_t i = count; i < components2.size(); ++i) {
69 if (components2[i] > 0) 69 if (components2[i] > 0)
70 return -1; 70 return -1;
71 } 71 }
72 } 72 }
73 return 0; 73 return 0;
74 } 74 }
75 75
76 } // namespace 76 } // namespace
77 77
78 namespace base {
brettw 2013/04/20 04:15:10 I usually just wrap the whole file (including the
xhwang 2013/04/20 05:53:44 Done.
79
78 Version::Version() { 80 Version::Version() {
79 } 81 }
80 82
81 Version::~Version() { 83 Version::~Version() {
82 } 84 }
83 85
84 Version::Version(const std::string& version_str) { 86 Version::Version(const std::string& version_str) {
85 std::vector<uint16> parsed; 87 std::vector<uint16> parsed;
86 if (!ParseVersionNumbers(version_str, &parsed)) 88 if (!ParseVersionNumbers(version_str, &parsed))
87 return; 89 return;
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 DCHECK(IsValid()); 165 DCHECK(IsValid());
164 std::string version_str; 166 std::string version_str;
165 size_t count = components_.size(); 167 size_t count = components_.size();
166 for (size_t i = 0; i < count - 1; ++i) { 168 for (size_t i = 0; i < count - 1; ++i) {
167 version_str.append(base::IntToString(components_[i])); 169 version_str.append(base::IntToString(components_[i]));
168 version_str.append("."); 170 version_str.append(".");
169 } 171 }
170 version_str.append(base::IntToString(components_[count - 1])); 172 version_str.append(base::IntToString(components_[count - 1]));
171 return version_str; 173 return version_str;
172 } 174 }
175
176 } // namespace base
OLDNEW
« no previous file with comments | « base/version.h ('k') | chrome/browser/component_updater/flash_component_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698