(Reland) set navigationStart based on CommonNavigationParams

Let RenderFrameImpl set navigationStart based on CommonNavigationParams

This change originally was reverted here:
https://codereview.chromium.org/1423453007/
Due to a flawed test. The test in question tries to set Blink's navigationStart timestamp based on the browsers navigation_start, but blink essentially ignores that for it's reporting to consumers, only using the TimeTicks value passed in for relative measures (i.e. all the other metrics).

Original description:
This entails setting the timestamp before we set it in blink, so DocumentLoadTiming had to be modified to allow for that. We set the value in didCreateDataSource.

didCreateDataSource was also refactored slightly so that same-page navigations don't need to call it anymore.

This is 2/3 of the effort to add a navigation_start timestamp to DidStartProvisional load. The full CL we're breaking up is here:
https://codereview.chromium.org/1425823002/

BUG=548335
Committed: https://crrev.com/1ce0e85b707637a8a4620cd58744993773d33bf9
Cr-Commit-Position: refs/heads/master@{#358532}

[Charlie Harrison, 2015-11-06 04:17:15]

Description was changed from

==========
Let RenderFrameImpl set navigationStart based on CommonNavigationParams

BUG=
==========

to

==========
Let RenderFrameImpl set navigationStart based on CommonNavigationParams

UNREVERT of 
https://codereview.chromium.org/1423453007/

This entails setting the timestamp before we set it in blink, so
DocumentLoadTiming had to be modified to allow for that. We set the value in
didCreateDataSource.

didCreateDataSource was also refactored slightly so that same-page navigations
don't need to call it anymore.

This is 2/3 of the effort to add a navigation_start timestamp to
DidStartProvisional load. The full CL we're breaking up is here:
https://codereview.chromium.org/1425823002/

BUG=548335
==========

[Charlie Harrison, 2015-11-06 04:18:49]

Description was changed from

==========
Let RenderFrameImpl set navigationStart based on CommonNavigationParams

UNREVERT of 
https://codereview.chromium.org/1423453007/

This entails setting the timestamp before we set it in blink, so
DocumentLoadTiming had to be modified to allow for that. We set the value in
didCreateDataSource.

didCreateDataSource was also refactored slightly so that same-page navigations
don't need to call it anymore.

This is 2/3 of the effort to add a navigation_start timestamp to
DidStartProvisional load. The full CL we're breaking up is here:
https://codereview.chromium.org/1425823002/

BUG=548335
==========

to

==========
Let RenderFrameImpl set navigationStart based on CommonNavigationParams

This change originally was reverted here:
https://codereview.chromium.org/1423453007/
Due to a what I believe is a flawed test.

This entails setting the timestamp before we set it in blink, so
DocumentLoadTiming had to be modified to allow for that. We set the value in
didCreateDataSource.

didCreateDataSource was also refactored slightly so that same-page navigations
don't need to call it anymore.

This is 2/3 of the effort to add a navigation_start timestamp to
DidStartProvisional load. The full CL we're breaking up is here:
https://codereview.chromium.org/1425823002/

BUG=548335
==========

[Charlie Harrison, 2015-11-06 13:08:00]

Description was changed from

==========
Let RenderFrameImpl set navigationStart based on CommonNavigationParams

This change originally was reverted here:
https://codereview.chromium.org/1423453007/
Due to a what I believe is a flawed test.

This entails setting the timestamp before we set it in blink, so
DocumentLoadTiming had to be modified to allow for that. We set the value in
didCreateDataSource.

didCreateDataSource was also refactored slightly so that same-page navigations
don't need to call it anymore.

This is 2/3 of the effort to add a navigation_start timestamp to
DidStartProvisional load. The full CL we're breaking up is here:
https://codereview.chromium.org/1425823002/

BUG=548335
==========

to

==========
Let RenderFrameImpl set navigationStart based on CommonNavigationParams

This change originally was reverted here:
https://codereview.chromium.org/1423453007/
Due to a flawed test. The test in question tries to set Blink's navigationStart
timestamp based on the browsers navigation_start, but blink essentially ignores
that for it's reporting to consumers, only using the TimeTicks value passed in
for relative measures (i.e. all the other metrics).

Original description:
This entails setting the timestamp before we set it in blink, so
DocumentLoadTiming had to be modified to allow for that. We set the value in
didCreateDataSource.

didCreateDataSource was also refactored slightly so that same-page navigations
don't need to call it anymore.

This is 2/3 of the effort to add a navigation_start timestamp to
DidStartProvisional load. The full CL we're breaking up is here:
https://codereview.chromium.org/1425823002/

BUG=548335
==========

[Charlie Harrison, 2015-11-06 13:08:00]

csharrison@chromium.org changed reviewers:
+ clamy@chromium.org, jochen@chromium.org

[Charlie Harrison, 2015-11-06 13:09:23]

This is the same CL as before, minus half a browsertest (which never did
anything meaningful in the first place). PTAL.

[clamy, 2015-11-06 14:11:35]

Thanks! Lgtm.
Note: for future relands, it is easier to review if you upload the original
patchset first, and then a patchset with the changes for the reland. This way
reviewers can see right away what changed.

[jochen (gone - plz use gerrit), 2015-11-07 05:54:17]

lgtm

[Charlie Harrison, 2015-11-07 15:11:15]

On 2015/11/07 05:54:17, jochen (slow - traveling) wrote:
> lgtm

clamy@, yeah good point in the future I will try to do that.

Thanks!

[Charlie Harrison, 2015-11-07 15:11:20]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2015-11-07 15:11:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409883008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409883008/1

[commit-bot: I haz the power, 2015-11-07 16:45:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-07 16:45:21]

CQ experienced an internal error when committing your CL and the maintainers
were notified. Sorry for the inconvenience.

[commit-bot: I haz the power, 2015-11-07 16:46:18]

Patchset 1 (id:??) landed as
https://crrev.com/1ce0e85b707637a8a4620cd58744993773d33bf9
Cr-Commit-Position: refs/heads/master@{#358532}