Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1409863006: Subzero. ARM32. Refactors atomic intrinsics lowering. (Closed)

Created:
5 years, 1 month ago by John
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+365 lines, -864 lines) Patch
M crosstest/test_sync_atomic.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M pydir/build-runtime.py View 1 3 chunks +41 lines, -6 lines 0 comments Download
M pydir/targets.py View 3 chunks +4 lines, -1 line 0 comments Download
M runtime/szrt_asm_arm32.s View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/szrt_asm_x8632.s View 2 chunks +2 lines, -0 lines 0 comments Download
M src/IceRegAlloc.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 2 chunks +25 lines, -3 lines 2 comments Download
M src/IceTargetLoweringARM32.cpp View 1 2 7 chunks +215 lines, -307 lines 4 comments Download
M tests_lit/assembler/arm32/ldrex-strex.ll View 1 2 4 chunks +47 lines, -513 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-intrinsics.ll View 20 chunks +27 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
John
4 years, 10 months ago (2016-02-12 21:03:33 UTC) #4
Jim Stichnoth
lgtm https://codereview.chromium.org/1409863006/diff/60001/src/IceTargetLoweringARM32.cpp File src/IceTargetLoweringARM32.cpp (right): https://codereview.chromium.org/1409863006/diff/60001/src/IceTargetLoweringARM32.cpp#newcode3412 src/IceTargetLoweringARM32.cpp:3412: auto *DestLo = llvm::cast<Variable>(loOperand(Dest)); Just curious - why ...
4 years, 10 months ago (2016-02-17 03:50:17 UTC) #5
John
Committed patchset #3 (id:60001) manually as 4b6e4b44a8abe5f4c5f209d45828cc1ef1bb6a1e (presubmit successful).
4 years, 10 months ago (2016-02-17 13:01:05 UTC) #7
John
4 years, 10 months ago (2016-02-17 13:01:39 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/1409863006/diff/60001/src/IceTargetLoweringAR...
File src/IceTargetLoweringARM32.cpp (right):

https://codereview.chromium.org/1409863006/diff/60001/src/IceTargetLoweringAR...
src/IceTargetLoweringARM32.cpp:3412: auto *DestLo =
llvm::cast<Variable>(loOperand(Dest));
On 2016/02/17 03:50:17, stichnot wrote:
> Just curious - why these changes?

I was fiddling around trying to avoid some unnecessary register copies, but I
decided against adding that to this CL. I forgot to revert this part of that
change. Done.

https://codereview.chromium.org/1409863006/diff/60001/src/IceTargetLoweringAR...
src/IceTargetLoweringARM32.cpp:4772: Type ValueTy = ValueR->getType();
On 2016/02/17 03:50:17, stichnot wrote:
> Surprised that "auto" wasn't used here.

not to mention the lack of constness... :)

Done.

https://codereview.chromium.org/1409863006/diff/60001/src/IceTargetLoweringAR...
File src/IceTargetLoweringARM32.h (right):

https://codereview.chromium.org/1409863006/diff/60001/src/IceTargetLoweringAR...
src/IceTargetLoweringARM32.h:264: /// end up writting to memory. Operation also
needs to handle fake-defing for
On 2016/02/17 03:50:17, stichnot wrote:
> writing

Done.

Powered by Google App Engine
This is Rietveld 408576698