Have NetworkStateNotifier keep untraced ExecutionContext observers.

Have NetworkStateNotifier keep untraced ExecutionContext observers.

NetworkStateNotifier keeps track of its observing ExecutionContexts;
following r355234 this is a persistent hash map of weak references
(with Oilpan.) As observers may live on any thread, the first thread
that registers would then create the persistent heap collection on its
heap. This is at odds with the lifetime of NetworkStateNotifier, and
as ExecutionContexts manually manage their observership, revert to using
a HashMap.

R=haraken
BUG=515524
Committed: https://crrev.com/f584f71dcd33f325fe4b86f271dbd6cdbdfc8802
Cr-Commit-Position: refs/heads/master@{#355970}

[sof, 2015-10-23 10:59:10]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-10-23 10:59:10]

please take a look.

Takes care of the netinfo/web-worker.html crasher


http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%...

[haraken, 2015-10-23 18:55:06]

LGTM, thanks. Worth having a comment about why the ObserverListMap needs to use
UntracedMembers.

[sof, 2015-10-24 07:31:22]

On 2015/10/23 18:55:06, haraken wrote:
> LGTM, thanks. Worth having a comment about why the ObserverListMap needs to
use
> UntracedMembers.

Added a comment trying to indicate the "why" of the representation used.

[sof, 2015-10-24 07:31:35]

Description was changed from

==========
Have NetworkStateNotifier keep untraced ExecutionContext observers.

NetworkStateNotifier keeps track of its observing ExecutionContexts;
following r355234 this is a persistent hash map of weak references
(with Oilpan.) As observers may live on any thread, the first thread
that registers would then create the persistent heap collection on its
heap. This is at odds with the lifetime of NetworkStateNotifier, and
as ExecutionContexts manually manage their observership, revert to using
a HashMap.

R=
BUG=515524
==========

to

==========
Have NetworkStateNotifier keep untraced ExecutionContext observers.

NetworkStateNotifier keeps track of its observing ExecutionContexts;
following r355234 this is a persistent hash map of weak references
(with Oilpan.) As observers may live on any thread, the first thread
that registers would then create the persistent heap collection on its
heap. This is at odds with the lifetime of NetworkStateNotifier, and
as ExecutionContexts manually manage their observership, revert to using
a HashMap.

R=haraken
BUG=515524
==========

[sof, 2015-10-24 07:31:40]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-10-24 07:31:40]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1409853007/#ps20001
(title: "add comment")

[commit-bot: I haz the power, 2015-10-24 07:31:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409853007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409853007/20001

[commit-bot: I haz the power, 2015-10-24 10:06:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-24 10:07:48]

Patchset 2 (id:??) landed as
https://crrev.com/f584f71dcd33f325fe4b86f271dbd6cdbdfc8802
Cr-Commit-Position: refs/heads/master@{#355970}