Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: src/core/SkPx.h

Issue 1409843005: Revert of SkPx: new approach to fixed-point SIMD (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/opts/SkBlitMask_opts.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkPx.h
diff --git a/src/core/SkPx.h b/src/core/SkPx.h
deleted file mode 100644
index 129fc07fbc4e5e8714f3cfe323639dcab4a7e0d4..0000000000000000000000000000000000000000
--- a/src/core/SkPx.h
+++ /dev/null
@@ -1,89 +0,0 @@
-/*
- * Copyright 2015 Google Inc.
- *
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file.
- */
-
-#ifndef SkPx_DEFINED
-#define SkPx_DEFINED
-
-#include "SkTypes.h"
-#include "SkColorPriv.h"
-
-// We'll include one of src/opts/SkPx_{sse,neon,none}.h to define a type SkPx.
-//
-// SkPx represents up to SkPx::N 8888 pixels. It's agnostic to whether these
-// are SkColors or SkPMColors; it only assumes that alpha is the high byte.
-static_assert(SK_A32_SHIFT == 24, "For both SkColor and SkPMColor, alpha is always the high byte.");
-//
-// SkPx::Alpha represents up to SkPx::N 8-bit values, usually coverage or alpha.
-// SkPx::Wide represents up to SkPx::N pixels with 16 bits per component.
-//
-// SkPx supports the following methods:
-// static SkPx Dup(uint32_t);
-// static SkPx Load(const uint32_t*);
-// static SkPx Load(const uint32_t*, int n); // where 0<n<SkPx::N
-// void store(uint32_t*) const;
-// void store(uint32_t*, int n) const; // where 0<n<SkPx::N
-//
-// Alpha alpha() const; // argb -> a
-// Wide widenLo() const; // argb -> 0a0r0g0b
-// Wide widenHi() const; // argb -> a0r0g0b0
-// Wide widenLoHi() const; // argb -> aarrggbb
-//
-// SkPx operator+(const SkPx&) const;
-// SkPx operator-(const SkPx&) const;
-// SkPx saturatedAdd(const SkPx&) const;
-//
-// Wide operator*(const Alpha&) const; // argb * A -> (a*A)(r*A)(g*A)(b*A)
-//
-// // Fast approximate (px*a+127)/255.
-// // Never off by more than 1, and always correct when px or a is 0 or 255.
-// // We use the approximation (px*a+px)/256.
-// SkPx approxMulDiv255(const Alpha&) const;
-//
-// SkPx addAlpha(const Alpha&) const; // argb + A -> (a+A)rgb
-//
-// SkPx::Alpha supports the following methods:
-// static Alpha Dup(uint8_t);
-// static Alpha Load(const uint8_t*);
-// static Alpha Load(const uint8_t*, int n); // where 0<n<SkPx::N
-//
-// Alpha inv() const; // a -> 255-a
-//
-// SkPx::Wide supports the following methods:
-// Wide operator+(const Wide&);
-// Wide operator-(const Wide&);
-// Wide operator<<(int bits);
-// Wide operator>>(int bits);
-//
-// // Return the high byte of each component of (*this + o.widenLo()).
-// SkPx addNarrowHi(const SkPx& o);
-//
-// Methods left unwritten, but certainly to come:
-// SkPx SkPx::operator<(const SkPx&) const;
-// SkPx SkPx::thenElse(const SkPx& then, const SkPx& else) const;
-// Wide Wide::operator<(const Wide&) const;
-// Wide Wide::thenElse(const Wide& then, const Wide& else) const;
-//
-// SkPx Wide::div255() const; // Rounds, think (*this + 127) / 255.
-//
-// The different implementations of SkPx have complete freedom to choose
-// SkPx::N and how they represent SkPx, SkPx::Alpha, and SkPx::Wide.
-//
-// All observable math must remain identical.
-
-#if defined(SKNX_NO_SIMD)
- #include "../opts/SkPx_none.h"
-#else
- #if SK_CPU_SSE_LEVEL >= SK_CPU_SSE_LEVEL_SSE2
- #include "../opts/SkPx_sse.h"
- #elif defined(SK_ARM_HAS_NEON)
- #include "../opts/SkPx_neon.h"
- #else
- #include "../opts/SkPx_none.h"
- #endif
-#endif
-
-#endif//SkPx_DEFINED
« no previous file with comments | « no previous file | src/opts/SkBlitMask_opts.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698