Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1409833013: include what you use: errno.h and string.h in ipc_channel_posix_unittest.cc (Closed)

Created:
5 years, 1 month ago by Mostyn Bramley-Moore
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

include what you use: errno.h and string.h in ipc_channel_posix_unittest.cc Add missing errno.h include for errno and string.h include for strerror. Committed: https://crrev.com/7b4ebfb6696736f87c897ee1f234805609eed99f Cr-Commit-Position: refs/heads/master@{#358467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ipc/ipc_channel_posix_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mostyn Bramley-Moore
@tsepez: here's an include-what-you-use fix.
5 years, 1 month ago (2015-11-06 23:59:54 UTC) #2
Tom Sepez
Thanks. LGTM.
5 years, 1 month ago (2015-11-07 00:03:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409833013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409833013/1
5 years, 1 month ago (2015-11-07 00:09:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-07 00:25:58 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-07 00:27:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b4ebfb6696736f87c897ee1f234805609eed99f
Cr-Commit-Position: refs/heads/master@{#358467}

Powered by Google App Engine
This is Rietveld 408576698